chore: update build artifacts for v1.4.18

.agent/rules/rules.md

@@ -48,6 +48,11 @@ trigger: always_on
 - **Browser**: Allowed for documentation and safe browsing. No automated logins without permission.
 - **Terminal**: No `rm -rf`. Run tests (`pytest` etc.) after logic changes.
 
+## 7. Mandatory Testing Policy 🧪
+**CRITICAL: No logic or UI fix is complete without a corresponding automated test.**
+- If you fix a regression or implement a new UI feature, you **MUST** write or update a test in `tests/test_dom.js` or `test_logic.js`. 
+- Refactoring MUST include verifying that no click listeners drop out. This guarantees that features like modal toggles stay functional.
+
 ## 7. Requirements-Konsistenz 📋
 Alle umgesetzten Anforderungen müssen mit `REQUIREMENTS.md` übereinstimmen.
 1.  **Vor der Umsetzung prüfen**: Passt die neue Anforderung zu den bestehenden Requirements?

build-bookmarklet.sh

@@ -258,6 +258,14 @@ if [ $LOGIC_EXIT -ne 0 ]; then
     exit 1
 fi
 
+echo "=== Running DOM Interaction Tests ==="
+node "$SCRIPT_DIR/tests/test_dom.js"
+DOM_EXIT=$?
+if [ $DOM_EXIT -ne 0 ]; then
+    echo "❌ DOM UI tests FAILED! Regressions detected."
+    exit 1
+fi
+
 echo "=== Running Build Tests ==="
 python3 "$SCRIPT_DIR/test_build.py"
 TEST_EXIT=$?

changelog.md

@@ -1,3 +1,10 @@
+## v1.4.18
+- 🧪 **Testing**: Die automatische DOM-Testing Suite (`test_dom.js`) wurde massiv ausgebaut. Sie prüft nun neben der Alarmglocke und den Highlights auch systematisch alle anderen UI-Komponenten (Login-Modal, History-Modal, Versionen-Modal, Theme-Toggle, und Navigation Tabs) auf korrekte Event-Listener-Bindungen, um Regressionen (tote Buttons) endgültig auszuschließen.
+
+## v1.4.17
+- 🐛 **Bugfix**: Regression behoben: Der "Persönliche Highlights" (Stern-Button) Dialog öffnet sich nun wieder korrekt.
+- 🧪 **Testing**: Es wurde ein initialer UI-Testing-Hook (`test_dom.js` mit `jsdom`) in die Build-Pipeline integriert, um kritische DOM Event-Listener Regressionen (wie den Highlights-Button und die Alarmglocke) automatisch zu preventen.
+
 ## v1.4.16
 - ⚡ **Feature**: Ein Button "Lokalen Cache leeren" wurde zum Versionen-Menü hinzugefügt, um bei hartnäckigen lokalen Fehlern alle Caches und Sessions bereinigen zu können, ohne die Entwicklertools (F12) des Browsers bemühen zu müssen.
 

debug_test.js

@@ -0,0 +1,15 @@
+const fs = require('fs');
+const jsCode = fs.readFileSync('kantine.js', 'utf8').replace('(function () {', '').replace(/}\)\(\);$/, '');
+try {
+    const vm = require('vm');
+    new vm.Script(jsCode);
+} catch (e) {
+    console.error(e.message);
+    const lines = jsCode.split('\n');
+    console.error("Around line", e.loc?.line);
+    if(e.loc?.line) {
+       console.log(lines[e.loc.line - 2]);
+       console.log(lines[e.loc.line - 1]);
+       console.log(lines[e.loc.line]);
+    }
+}

dist/kantine-standalone.html

@@ -2021,7 +2021,7 @@ body {
                     <div class="brand">
                         <span class="material-icons-round logo-icon">restaurant_menu</span>
                         <div class="header-left">
-                            <h1>Kantinen Übersicht <small class="version-tag" style="font-size: 0.6em; opacity: 0.7; font-weight: 400; cursor: pointer;" title="Klick für Versionsmenü">v1.4.16</small></h1>
+                            <h1>Kantinen Übersicht <small class="version-tag" style="font-size: 0.6em; opacity: 0.7; font-weight: 400; cursor: pointer;" title="Klick für Versionsmenü">v1.4.18</small></h1>
                             <div id="last-updated-subtitle" class="subtitle"></div>
                         </div>
                         <div class="nav-group" style="margin-left: 1rem;">
@@ -2163,7 +2163,7 @@ body {
                     </div>
                     <div class="modal-body">
                         <div style="margin-bottom: 1rem;">
-                            <strong>Aktuell:</strong> <span id="version-current">v1.4.16</span>
+                            <strong>Aktuell:</strong> <span id="version-current">v1.4.18</span>
                         </div>
                         <div class="dev-toggle">
                             <label style="display:flex;align-items:center;gap:8px;cursor:pointer;">
@@ -2231,6 +2231,18 @@ body {
         const historyModal = document.getElementById('history-modal');
         const btnHistoryClose = document.getElementById('btn-history-close');
 
+        if (btnHighlights) {
+            btnHighlights.addEventListener('click', () => {
+                highlightsModal.classList.remove('hidden');
+            });
+        }
+
+        if (btnHighlightsClose) {
+            btnHighlightsClose.addEventListener('click', () => {
+                highlightsModal.classList.add('hidden');
+            });
+        }
+
         btnHistory.addEventListener('click', () => {
             if (!authToken) {
                 loginModal.classList.remove('hidden');
@@ -3998,7 +4010,7 @@ body {
 
     // Periodic update check (runs on init + every hour)
     async function checkForUpdates() {
-        const currentVersion = 'v1.4.16';
+        const currentVersion = 'v1.4.18';
         const devMode = localStorage.getItem('kantine_dev_mode') === 'true';
 
         try {
@@ -4039,7 +4051,7 @@ body {
         const modal = document.getElementById('version-modal');
         const container = document.getElementById('version-list-container');
         const devToggle = document.getElementById('dev-mode-toggle');
-        const currentVersion = 'v1.4.16';
+        const currentVersion = 'v1.4.18';
 
         if (!modal) return;
         modal.classList.remove('hidden');

kantine.js

@@ -281,6 +281,18 @@
         const historyModal = document.getElementById('history-modal');
         const btnHistoryClose = document.getElementById('btn-history-close');
 
+        if (btnHighlights) {
+            btnHighlights.addEventListener('click', () => {
+                highlightsModal.classList.remove('hidden');
+            });
+        }
+
+        if (btnHighlightsClose) {
+            btnHighlightsClose.addEventListener('click', () => {
+                highlightsModal.classList.add('hidden');
+            });
+        }
+
         btnHistory.addEventListener('click', () => {
             if (!authToken) {
                 loginModal.classList.remove('hidden');

syntax_check.js

@@ -0,0 +1,17 @@
+const fs = require('fs');
+const jsCode = fs.readFileSync('kantine.js', 'utf8')
+    .replace('(function () {', '')
+    .replace('})();', '')
+    .replace('if (window.__KANTINE_LOADED) return;', '');
+const testCode = `
+    console.log("TEST");
+`;
+const code = jsCode + '\n' + testCode;
+try {
+    const vm = require('vm');
+    new vm.Script(code);
+} catch (e) {
+    if(e.stack) {
+       console.log("Syntax error at:", e.stack.split('\n').slice(0,3).join('\n'));
+    }
+}

tests/test_dom.js

@@ -1,7 +1,12 @@
 const fs = require('fs');
+fs.writeFileSync('trace.log', '');
+function log(m) { fs.appendFileSync('trace.log', m + '\n'); }
+
+log("Initializing JSDOM...");
 const jsdom = require('jsdom');
 const { JSDOM } = jsdom;
 
+log("Reading html...");
 const html = `
 <!DOCTYPE html>
 <html>
@@ -15,35 +20,165 @@ const html = `
     <button id="alarm-bell" class="icon-btn hidden">
         <span id="alarm-bell-icon" style="color:var(--text-secondary);"></span>
     </button>
+    
+    <!-- Mocks for Highlights Feature -->
+    <button id="btn-highlights">Highlights</button>
+    <div id="highlights-modal" class="modal hidden">
+        <button id="btn-highlights-close">Close</button>
+        <input id="tag-input" type="text" />
+        <button id="btn-add-tag">Add</button>
+        <ul id="tags-list"></ul>
+    </div>
+    
+    <!-- Mocks for Login Modal -->
+    <button id="btn-login-open">Login</button>
+    <div id="login-modal" class="modal hidden">
+        <button id="btn-login-close">Close</button>
+        <form id="login-form"></form>
+        <div id="login-error" class="hidden"></div>
+    </div>
+    
+    <!-- Mocks for History Modal -->
+    <button id="btn-history">History</button>
+    <div id="history-modal" class="modal hidden">
+        <button id="btn-history-close">Close</button>
+        <div id="history-loading" class="hidden"></div>
+        <div id="history-content"></div>
+    </div>
+
+    <!-- Mocks for Version Modal -->
+    <span class="version-tag">v1.4.17</span>
+    <div id="version-modal" class="modal hidden">
+        <button id="btn-version-close">Close</button>
+        <button id="btn-clear-cache">Clear</button>
+        <span id="version-current"></span>
+        <div id="version-list-container"></div>
+    </div>
+
+    <!-- Mocks for Theme Toggle -->
+    <button id="theme-toggle"><span class="theme-icon">light_mode</span></button>
+
+    <!-- Mocks for Navigation Tabs -->
+    <button id="btn-this-week" class="active">This Week</button>
+    <button id="btn-next-week">Next Week</button>
+    
+    <button id="btn-refresh">Refresh</button>
+    <button id="btn-logout">Logout</button>
+    <div class="order-history-header">Header</div>
+    <button id="btn-error-redirect">Error Redirect</button>
 </body>
 </html>
 `;
 
-const jsCode = fs.readFileSync('kantine.js', 'utf8').replace('(function () {', '').replace(/}\)\(\);$/, '');
+log("Reading file jsCode...");
+const jsCode = fs.readFileSync('kantine.js', 'utf8')
+    .replace('(function () {', '')
+    .replace('})();', '')
+    .replace('if (window.__KANTINE_LOADED) return;', '')
+    .replace('window.location.reload();', 'window.__RELOAD_CALLED = true;');
 
-const dom = new JSDOM(html, { runScripts: "dangerously" });
+log("Instantiating JSDOM...");
+const dom = new JSDOM(html, { runScripts: "dangerously", url: "http://localhost/" });
+log("JSDOM dom created...");
 global.window = dom.window;
 global.document = window.document;
-global.localStorage = { getItem: () => '[]', setItem: () => {} };
+global.localStorage = { getItem: () => '[]', setItem: () => { } };
 global.sessionStorage = { getItem: () => null };
 
-global.showToast = () => {};
+global.showToast = () => { };
-global.saveFlags = () => {};
+global.saveFlags = () => { };
-global.renderVisibleWeeks = () => {};
+global.renderVisibleWeeks = () => { };
 // Mock missing browser features if needed
-global.Notification = { permission: 'default', requestPermission: () => {} };
+global.Notification = { permission: 'default', requestPermission: () => { } };
+global.window.matchMedia = () => ({ matches: false, addListener: () => { }, removeListener: () => { } });
+global.fetch = () => Promise.resolve({ ok: true, json: () => Promise.resolve({ results: [] }) });
+global.window.fetch = global.fetch;
 
-try {
+log("Before eval...");
-    dom.window.eval(jsCode);
+const testCode = `
-    console.log("Initial Bell Classes:", window.document.getElementById('alarm-bell').className);
+        console.log("--- Testing Alarm Bell ---");
+        // Add flag
+        userFlags.add('2026-02-24_123'); updateAlarmBell();
+        if (document.getElementById('alarm-bell').className.includes('hidden')) throw new Error("Bell should be visible");
 
-    // Add flag
+        // Remove flag
-    dom.window.eval("userFlags.add('2026-02-24_123'); updateAlarmBell();");
+        userFlags.delete('2026-02-24_123'); updateAlarmBell();
-    console.log("After Add:", window.document.getElementById('alarm-bell').className);
+        if (!document.getElementById('alarm-bell').className.includes('hidden')) throw new Error("Bell should be hidden");
 
-    // Remove flag
+        console.log("✅ Alarm Bell Test Passed");
-    dom.window.eval("userFlags.delete('2026-02-24_123'); updateAlarmBell();");
+
-    console.log("After Remove:", window.document.getElementById('alarm-bell').className);
+        console.log("--- Testing Highlights Modal ---");
-} catch (e) {
+        // First, verify initial state
-    console.error(e);
+        const hlModal = document.getElementById('highlights-modal');
+        if (!hlModal.classList.contains('hidden')) throw new Error("Highlights modal should be hidden initially");
+
+        // Click to open
+        document.getElementById('btn-highlights').click();
+        if (hlModal.classList.contains('hidden')) throw new Error("Highlights modal did not open upon clicking btn-highlights!");
+
+        // Click to close
+        document.getElementById('btn-highlights-close').click();
+        if (!hlModal.classList.contains('hidden')) throw new Error("Highlights modal did not close upon clicking btn-highlights-close!");
+
+        console.log("✅ Highlights Modal Test Passed");
+        
+        console.log("--- Testing Login Modal ---");
+        const loginModal = document.getElementById('login-modal');
+        document.getElementById('btn-login-open').click();
+        if (loginModal.classList.contains('hidden')) throw new Error("Login modal should open");
+        document.getElementById('btn-login-close').click();
+        if (!loginModal.classList.contains('hidden')) throw new Error("Login modal should close");
+        console.log("✅ Login Modal Test Passed");
+
+        console.log("--- Testing History Modal ---");
+        // We need authToken to be truthy to open history modal
+        authToken = "fake_token";
+        const historyModal = document.getElementById('history-modal');
+        document.getElementById('btn-history').click();
+        if (historyModal.classList.contains('hidden')) throw new Error("History modal should open");
+        document.getElementById('btn-history-close').click();
+        if (!historyModal.classList.contains('hidden')) throw new Error("History modal should close");
+        console.log("✅ History Modal Test Passed");
+
+        console.log("--- Testing Version Modal ---");
+        const versionModal = document.getElementById('version-modal');
+        document.querySelector('.version-tag').click();
+        if (versionModal.classList.contains('hidden')) throw new Error("Version modal should open");
+        document.getElementById('btn-version-close').click();
+        if (!versionModal.classList.contains('hidden')) throw new Error("Version modal should close");
+        console.log("✅ Version Modal Test Passed");
+
+        console.log("--- Testing Theme Toggle ---");
+        const themeBtn = document.getElementById('theme-toggle');
+        const initialTheme = document.documentElement.getAttribute('data-theme');
+        themeBtn.click();
+        const newTheme = document.documentElement.getAttribute('data-theme');
+        if (initialTheme === newTheme) throw new Error("Theme did not toggle");
+        console.log("✅ Theme Toggle Test Passed");
+
+        console.log("--- Testing Navigation Tabs ---");
+        const btnThis = document.getElementById('btn-this-week');
+        const btnNext = document.getElementById('btn-next-week');
+        btnNext.click();
+        if (!btnNext.classList.contains('active') || btnThis.classList.contains('active')) throw new Error("Next week tab not active");
+        btnThis.click();
+        if (!btnThis.classList.contains('active') || btnNext.classList.contains('active')) throw new Error("This week tab not active");
+        console.log("✅ Navigation Tabs Test Passed");
+        
+        console.log("--- Testing Clear Cache Button ---");
+        // Mock confirm directly inside evaluated JSDOM context
+        window.confirm = () => true;
+        document.getElementById('btn-clear-cache').click();
+        if (!window.__RELOAD_CALLED) throw new Error("Clear cache did not reload the page");
+        console.log("✅ Clear Cache Button Test Passed");
+
+        window.__TEST_PASSED = true;
+    `;
+
+dom.window.eval(jsCode + "\n" + testCode);
+
+if (!dom.window.__TEST_PASSED) {
+    throw new Error("Tests failed to reach completion inside JSDOM.");
 }
+
+process.exit(0);

version.txt

@@ -1 +1 @@
-v1.4.16
+v1.4.18